fix: Upload OTKs if the otk_count field is missing

fixes #180

lib/encryption/olm_manager.dart

@@ -262,19 +262,25 @@ class OlmManager {
     final haveFallbackKeys = encryption.isMinOlmVersion(3, 2, 0);
     // Check if there are at least half of max_number_of_one_time_keys left on the server
     // and generate and upload more if not.
-    if ((countJson != null &&
+
-            ((countJson.containsKey('signed_curve25519') &&
+    // If the server did not send us a count, assume it is 0
-                    countJson['signed_curve25519'] <
+    final keyCount = countJson?.tryGet<int>('signed_curve25519', 0) ?? 0;
-                        (_olmAccount.max_number_of_one_time_keys() / 2)) ||
+
-                !countJson.containsKey('signed_curve25519'))) ||
+    // If the server does not support fallback keys, it will not tell us about them.
-        (haveFallbackKeys &&
+    // If the server supports them but has no key, upload a new one.
-            unusedFallbackKeyTypes?.contains('signed_curve25519') == false)) {
+    var unusedFallbackKey = true;
+    if (unusedFallbackKeyTypes?.contains('signed_curve25519') == false) {
+      unusedFallbackKey = false;
+    }
+
+    // Only upload keys if they are less than half of the max or we have no unused fallback key
+    if (keyCount < (_olmAccount.max_number_of_one_time_keys() / 2) ||
+        !unusedFallbackKey) {
       uploadKeys(
-        oldKeyCount:
+        oldKeyCount: keyCount < (_olmAccount.max_number_of_one_time_keys() / 2)
-            countJson != null ? (countJson['signed_curve25519'] ?? 0) : null,
+            ? keyCount
-        unusedFallbackKey: haveFallbackKeys
-            ? unusedFallbackKeyTypes?.contains('signed_curve25519')
             : null,
+        unusedFallbackKey: haveFallbackKeys ? unusedFallbackKey : null,
       );
     }
   }

lib/src/client.dart

@@ -1184,9 +1184,7 @@ class Client extends MatrixApi {
     if (sync.deviceLists != null) {
       await _handleDeviceListsEvents(sync.deviceLists);
     }
-    if ((sync.deviceUnusedFallbackKeyTypes != null ||
+    if (encryptionEnabled) {
-            sync.deviceOneTimeKeysCount != null) &&
-        encryptionEnabled) {
       encryption.handleDeviceOneTimeKeysCount(
           sync.deviceOneTimeKeysCount, sync.deviceUnusedFallbackKeyTypes);
     }

test/client_test.dart

@@ -614,8 +614,9 @@ void main() {
       expect(client2.deviceID, client1.deviceID);
       expect(client2.deviceName, client1.deviceName);
       if (client2.encryptionEnabled) {
-        expect(client2.encryption.pickledOlmAccount,
+        expect(client2.encryption.fingerprintKey,
-            client1.encryption.pickledOlmAccount);
+            client1.encryption.fingerprintKey);
+        expect(client2.encryption.identityKey, client1.encryption.identityKey);
         expect(client2.rooms[1].id, client1.rooms[1].id);
       }
 

test/encryption/olm_manager_test.dart

@@ -112,13 +112,14 @@ void main() {
           FakeMatrixApi.calledEndpoints.containsKey('/client/r0/keys/upload'),
           true);
 
+      // this will upload keys because we assume the key count is 0, if the server doesn't send one
       FakeMatrixApi.calledEndpoints.clear();
       client.encryption.olmManager
           .handleDeviceOneTimeKeysCount(null, ['signed_curve25519']);
       await Future.delayed(Duration(milliseconds: 50));
       expect(
           FakeMatrixApi.calledEndpoints.containsKey('/client/r0/keys/upload'),
-          false);
+          true);
     });
 
     test('restoreOlmSession', () async {