fix: Deep-copy arrays correctly

This commit is contained in:
Sorunome 2021-01-17 15:38:09 +01:00
parent 8f1d35e0bc
commit 195d46b901
No known key found for this signature in database
GPG Key ID: B19471D07FC9BE9C
2 changed files with 36 additions and 14 deletions

View File

@ -22,16 +22,25 @@
*/ */
extension MapCopyExtension on Map<String, dynamic> { extension MapCopyExtension on Map<String, dynamic> {
dynamic _copyValue(dynamic value) {
if (value is Map<String, dynamic>) {
return value.copy();
}
if (value is List) {
final ret = [];
for (final val in value) {
ret.add(_copyValue(val));
}
return ret;
}
return value;
}
/// Deep-copies a given json map /// Deep-copies a given json map
Map<String, dynamic> copy() { Map<String, dynamic> copy() {
final copy = Map<String, dynamic>.from(this); final copy = Map<String, dynamic>.from(this);
for (final entry in copy.entries) { for (final entry in copy.entries) {
if (entry.value is Map<String, dynamic>) { copy[entry.key] = _copyValue(entry.value);
copy[entry.key] = (entry.value as Map<String, dynamic>).copy();
}
if (entry.value is List) {
copy[entry.key] = List.from(entry.value);
}
} }
return copy; return copy;
} }

View File

@ -40,5 +40,18 @@ void main() {
original['child']['list'].add(3); original['child']['list'].add(3);
expect(copy['child']['list'], [1, 2]); expect(copy['child']['list'], [1, 2]);
}); });
test('should do arrays', () {
final original = <String, dynamic>{
'arr': [
[1, 2],
{'beep': 'boop'},
],
};
final copy = original.copy();
original['arr'][0].add(3);
expect(copy['arr'][0], [1, 2]);
original['arr'][1]['beep'] = 'blargh';
expect(copy['arr'][1]['beep'], 'boop');
});
}); });
} }