OfficialDakari
/
matrix-dart-sdk
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Missing null fallback when update notificationCount 

Previously when using RoomUpdate in the constructor the notificationCount to update
was never null and set to 0 if it was missing. Now that we are
no longer using it, I forgot to
add the null fallback at this point.
This leads to serious crashes in the apps at runtime
and thats why I bump the version here as well!
This commit is contained in:
Krille Fear 2021-09-13 16:42:55 +02:00
parent 61ad497ea6
commit 1e2ccabe85
3 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGELOG.md
View File

@ -1,3 +1,6 @@
## [0.5.1] - 13nd Sep 2021
- fix: Room.notificationCount set to null sometimes
## [0.5.0] - 13nd Sep 2021 ## [0.5.0] - 13nd Sep 2021
- hotfix: Key sharing security vulnerability! -> Please upgrade as soon as possible to this version - hotfix: Key sharing security vulnerability! -> Please upgrade as soon as possible to this version
- feat: MSC2746: Improved Signalling for 1:1 VoIP - feat: MSC2746: Improved Signalling for 1:1 VoIP

5
lib/src/client.dart
View File

@ -1513,8 +1513,9 @@ class Client extends MatrixApi {
chatUpdate.timeline?.prevBatch != null)) { chatUpdate.timeline?.prevBatch != null)) {
rooms[j].membership = membership; rooms[j].membership = membership;
rooms[j].notificationCount = rooms[j].notificationCount =
chatUpdate.unreadNotifications?.notificationCount; chatUpdate.unreadNotifications?.notificationCount ?? 0;
rooms[j].highlightCount = chatUpdate.unreadNotifications?.highlightCount; rooms[j].highlightCount =
chatUpdate.unreadNotifications?.highlightCount ?? 0;
if (chatUpdate.timeline?.prevBatch != null) { if (chatUpdate.timeline?.prevBatch != null) {
rooms[j].prev_batch = chatUpdate.timeline?.prevBatch; rooms[j].prev_batch = chatUpdate.timeline?.prevBatch;
} }

2
pubspec.yaml
View File

@ -1,6 +1,6 @@
name: matrix name: matrix
description: Matrix Dart SDK description: Matrix Dart SDK
version: 0.5.0 version: 0.5.1
homepage: https://famedly.com homepage: https://famedly.com
environment: environment: