OfficialDakari
/
matrix-dart-sdk
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch 'MTRNord/perf-opt-3' into 'main' 

fix: Use where and map instead of a loop and a removeWhere

See merge request famedly/company/frontend/famedlysdk!937
This commit is contained in:
Nicolas Werner 2022-01-17 22:06:29 +00:00
parent 33b1302fc2 1b11efc9eb
commit 2205ffb084
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/src/room.dart
View File

@ -1158,16 +1158,15 @@ class Room {
Membership.invite, Membership.invite,
Membership.knock, Membership.knock,
]]) { ]]) {
final userList = <User>[];
final members = states[EventTypes.RoomMember]; final members = states[EventTypes.RoomMember];
if (members != null) { if (members != null) {
for (final entry in members.entries) { return members.entries
final state = entry.value; .where((entry) => entry.value.type == EventTypes.RoomMember)
if (state.type == EventTypes.RoomMember) userList.add(state.asUser); .map((entry) => entry.value.asUser)
} .where((user) => membershipFilter.contains(user.membership))
.toList();
} }
userList.removeWhere((u) => !membershipFilter.contains(u.membership)); return <User>[];
return userList;
} }
bool _requestedParticipants = false; bool _requestedParticipants = false;