Merge branch 'krille/send-files-easier' into 'main'

fix: Store sending files in database and fix retrying to send them

See merge request famedly/company/frontend/famedlysdk!999
This commit is contained in:
Nicolas Werner 2022-04-01 13:18:34 +00:00
commit 245246460d
3 changed files with 14 additions and 6 deletions

View File

@ -327,13 +327,20 @@ class Event extends MatrixEvent {
/// Try to send this event again. Only works with events of status -1. /// Try to send this event again. Only works with events of status -1.
Future<String?> sendAgain({String? txid}) async { Future<String?> sendAgain({String? txid}) async {
if (!status.isError) return null; if (!status.isError) return null;
// If this is a failed file sending event, try to fetch the file from the
// database first.
final url = getAttachmentUrl();
if (url?.scheme == 'local') {
final file = await downloadAndDecryptAttachment();
return await room.sendFileEvent(file, extraContent: content);
}
// we do not remove the event here. It will automatically be updated // we do not remove the event here. It will automatically be updated
// in the `sendEvent` method to transition -1 -> 0 -> 1 -> 2 // in the `sendEvent` method to transition -1 -> 0 -> 1 -> 2
final newEventId = await room.sendEvent( return await room.sendEvent(
content, content,
txid: txid ?? unsigned?['transaction_id'] ?? eventId, txid: txid ?? unsigned?['transaction_id'] ?? eventId,
); );
return newEventId;
} }
/// Whether the client is allowed to redact this event. /// Whether the client is allowed to redact this event.

View File

@ -695,7 +695,7 @@ class Room {
/// Set [shrinkImageMaxDimension] to for example `1600` if you want to shrink /// Set [shrinkImageMaxDimension] to for example `1600` if you want to shrink
/// your image before sending. This is ignored if the File is not a /// your image before sending. This is ignored if the File is not a
/// [MatrixImageFile]. /// [MatrixImageFile].
Future<Uri> sendFileEvent( Future<String?> sendFileEvent(
MatrixFile file, { MatrixFile file, {
String? txid, String? txid,
Event? inReplyTo, Event? inReplyTo,
@ -755,6 +755,7 @@ class Room {
name: file.name, name: file.name,
maxDimension: shrinkImageMaxDimension, maxDimension: shrinkImageMaxDimension,
customImageResizer: client.customImageResizer, customImageResizer: client.customImageResizer,
compute: client.runInBackground,
); );
} }
} }
@ -859,14 +860,14 @@ class Room {
}, },
if (extraContent != null) ...extraContent, if (extraContent != null) ...extraContent,
}; };
await sendEvent( final eventId = await sendEvent(
content, content,
txid: txid, txid: txid,
inReplyTo: inReplyTo, inReplyTo: inReplyTo,
editEventId: editEventId, editEventId: editEventId,
); );
sendingFilePlaceholders.remove(txid); sendingFilePlaceholders.remove(txid);
return uploadResp; return eventId;
} }
Future<String?> _sendContent( Future<String?> _sendContent(

View File

@ -745,7 +745,7 @@ void main() {
test('sendFileEvent', () async { test('sendFileEvent', () async {
final testFile = MatrixFile(bytes: Uint8List(0), name: 'file.jpeg'); final testFile = MatrixFile(bytes: Uint8List(0), name: 'file.jpeg');
final dynamic resp = await room.sendFileEvent(testFile, txid: 'testtxid'); final dynamic resp = await room.sendFileEvent(testFile, txid: 'testtxid');
expect(resp.toString(), 'mxc://example.com/AQwafuaFswefuhsfAFAgsw'); expect(resp.toString(), '\$event10');
}); });
test('pushRuleState', () async { test('pushRuleState', () async {