OfficialDakari
/
matrix-dart-sdk
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: stopMediaStream on all streams and make sure dispose runs everytime

This commit is contained in:
td 2023-04-12 16:36:05 +05:30
parent ebcf5872c5
commit 32ba85dc74
No known key found for this signature in database
GPG Key ID: F6D9E9BF14C7D103
1 changed files with 14 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
lib/src/voip/call.dart
View File

@ -102,15 +102,15 @@ class WrappedMediaStream {
Future<void> dispose() async {
renderer.srcObject = null;
if (isLocal()) {
if (isWeb) {
await stopMediaStream(stream);
} else {
if (!isGroupCall) {
await stopMediaStream(stream);
}
}
/// libwebrtc does not provide a way to clone MediaStreams. So stopping the
/// local stream here would break calls with all other participants if anyone
/// leaves. The local stream is manually disposed when user leaves. On web
/// streams are actually cloned.
if (!isGroupCall || isWeb) {
await stopMediaStream(stream);
}
stream = null;
await renderer.dispose();
}
@ -1386,12 +1386,17 @@ class CallSession {
await stream.dispose();
}
streams.clear();
} catch (e) {
Logs().e('[VOIP] cleaning up streams failed', e);
}
try {
if (pc != null) {
await pc!.close();
await pc!.dispose();
}
} catch (e) {
Logs().e('cleaning up streams failed', e);
Logs().e('[VOIP] removing pc failed', e);
}
}