OfficialDakari
/
matrix-dart-sdk
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Make room.setPower more type safe and avoid change powerlevel in RAM before sending request to server 

This fixes the bug that the
actual dart Map in the state
has been manipulated because
we have not worked with a
copy of the map. Also this
crashes if the powerlevelmap
would had a wrong type in
users.
This commit is contained in:
krille-chan 2024-04-17 09:46:27 +02:00
parent cebc00cb39
commit 4732580c3d
No known key found for this signature in database
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/src/room.dart
View File

@ -1201,11 +1201,15 @@ class Room {
/// Returns the event ID of the new state event. If there is no known
/// power level event, there might something broken and this returns null.
Future<String> setPower(String userID, int power) async {
var powerMap = getState(EventTypes.RoomPowerLevels)?.content;
if (powerMap is! Map<String, dynamic>) {
powerMap = <String, dynamic>{};
}
(powerMap['users'] ??= {})[userID] = power;
final powerMap = Map<String, Object?>.from(
getState(EventTypes.RoomPowerLevels)?.content ?? {},
);
final usersPowerMap = powerMap['users'] is Map<String, Object?>
? powerMap['users'] as Map<String, Object?>
: (powerMap['users'] = <String, Object?>{});
usersPowerMap[userID] = power;
return await client.setRoomStateWithKey(
id,