From 538865f62af54f2dcb3fc8a158091d5164955d8f Mon Sep 17 00:00:00 2001
From: td <j.nirve@famedly.com>
Date: Tue, 27 Jun 2023 13:46:39 +0530
Subject: [PATCH] chore: cleanup some eventTypes and unused variables

---
 lib/encryption/utils/key_verification.dart     | 14 ++++++--------
 test/encryption/key_verification_test.dart     |  2 +-
 test/encryption/qr_verification_self_test.dart |  2 +-
 3 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/lib/encryption/utils/key_verification.dart b/lib/encryption/utils/key_verification.dart
index 03f32ffd..c98c3d58 100644
--- a/lib/encryption/utils/key_verification.dart
+++ b/lib/encryption/utils/key_verification.dart
@@ -233,7 +233,6 @@ class KeyVerification {
       canceled ||
       {KeyVerificationState.error, KeyVerificationState.done}.contains(state);
 
-  String? chosenMethod;
   // qr stuff
   QRCode? qrCode;
   String? randomSharedSecretForQRCode;
@@ -293,7 +292,6 @@ class KeyVerification {
   /// qr, send the qrData you just scanned
   Future<void> continueVerification(String type,
       {Uint8List? qrDataRawBytes}) async {
-    chosenMethod = type;
     bool qrChecksOut = false;
     if (possibleMethods.contains(type)) {
       if (qrDataRawBytes != null) {
@@ -411,7 +409,7 @@ class KeyVerification {
 
           setState(KeyVerificationState.askAccept);
           break;
-        case 'm.key.verification.ready':
+        case EventTypes.KeyVerificationReady:
           if (deviceId == '*') {
             _deviceId = payload['from_device']; // gotta set the real device id
             transactionId ??= eventId ?? payload['transaction_id'];
@@ -498,7 +496,7 @@ class KeyVerification {
           }
           if (!(await verifyLastStep([
             EventTypes.KeyVerificationRequest,
-            'm.key.verification.ready',
+            EventTypes.KeyVerificationReady,
           ]))) {
             return; // abort
           }
@@ -642,7 +640,7 @@ class KeyVerification {
         }
       }
       // we need to send a ready event
-      await send('m.key.verification.ready', {
+      await send(EventTypes.KeyVerificationReady, {
         'methods': copyKnownVerificationMethods,
       });
       // setup QRData from incoming request (outgoing ready)
@@ -1129,7 +1127,7 @@ class _KeyVerificationMethodQRReciprocate extends _KeyVerificationMethod {
       switch (type) {
         case EventTypes.KeyVerificationStart:
           if (!(await request.verifyLastStep([
-            'm.key.verification.ready',
+            EventTypes.KeyVerificationReady,
             EventTypes.KeyVerificationRequest,
           ]))) {
             return; // abort
@@ -1248,7 +1246,7 @@ class _KeyVerificationMethodSas extends _KeyVerificationMethod {
       switch (type) {
         case EventTypes.KeyVerificationStart:
           if (!(await request.verifyLastStep([
-            'm.key.verification.ready',
+            EventTypes.KeyVerificationReady,
             EventTypes.KeyVerificationRequest,
             EventTypes.KeyVerificationStart
           ]))) {
@@ -1262,7 +1260,7 @@ class _KeyVerificationMethodSas extends _KeyVerificationMethod {
           break;
         case EventTypes.KeyVerificationAccept:
           if (!(await request.verifyLastStep([
-            'm.key.verification.ready',
+            EventTypes.KeyVerificationReady,
             EventTypes.KeyVerificationRequest
           ]))) {
             return;
diff --git a/test/encryption/key_verification_test.dart b/test/encryption/key_verification_test.dart
index d89937da..8ad2dfdd 100644
--- a/test/encryption/key_verification_test.dart
+++ b/test/encryption/key_verification_test.dart
@@ -518,7 +518,7 @@ void main() async {
           .handleEventUpdate(EventUpdate(
         content: {
           'event_id': req2.transactionId,
-          'type': 'm.key.verification.ready',
+          'type': EventTypes.KeyVerificationReady,
           'content': {
             'methods': [EventTypes.Sas],
             'from_device': 'SOMEOTHERDEVICE',
diff --git a/test/encryption/qr_verification_self_test.dart b/test/encryption/qr_verification_self_test.dart
index 3897a1b6..1fe1c1bb 100644
--- a/test/encryption/qr_verification_self_test.dart
+++ b/test/encryption/qr_verification_self_test.dart
@@ -51,7 +51,7 @@ void main() async {
     }
     await req1.client.encryption!.keyVerificationManager.handleToDeviceEvent(
       ToDeviceEvent(
-        type: 'm.key.verification.ready',
+        type: EventTypes.KeyVerificationReady,
         sender: req2.client.userID!,
         content: {
           'from_device': req2.client.deviceID,