OfficialDakari
/
matrix-dart-sdk
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch 'td/initWithStreamForGroupCall' into 'main' 

fix: allow passing a WrappedMediaStream to GroupCall.enter() to use as the local user media stream

See merge request famedly/company/frontend/famedlysdk!1275
This commit is contained in:
td 2023-04-25 09:22:04 +00:00
parent 2ecb09e555 046e2caf7d
commit 970551d8cb
1 changed files with 38 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
lib/src/voip/group_call.dart
View File

@ -348,13 +348,21 @@ class GroupCall {
/// Initializes the local user media stream. /// Initializes the local user media stream.
/// The media stream must be prepared before the group call enters. /// The media stream must be prepared before the group call enters.
Future<WrappedMediaStream> initLocalStream() async { /// if you allow the user to configure their camera and such ahead of time,
/// you can pass that `stream` on to this function.
/// This allows you to configure the camera before joining the call without
/// having to reopen the stream and possibly losing settings.
Future<WrappedMediaStream> initLocalStream(
{WrappedMediaStream? stream}) async {
if (state != GroupCallState.LocalCallFeedUninitialized) { if (state != GroupCallState.LocalCallFeedUninitialized) {
throw Exception('Cannot initialize local call feed in the $state state.'); throw Exception('Cannot initialize local call feed in the $state state.');
} }
setState(GroupCallState.InitializingLocalCallFeed); setState(GroupCallState.InitializingLocalCallFeed);
WrappedMediaStream localWrappedMediaStream;
if (stream == null) {
MediaStream stream; MediaStream stream;
try { try {
@ -366,7 +374,7 @@ class GroupCall {
} }
final userId = client.userID; final userId = client.userID;
final newStream = WrappedMediaStream( localWrappedMediaStream = WrappedMediaStream(
renderer: voip.delegate.createRenderer(), renderer: voip.delegate.createRenderer(),
stream: stream, stream: stream,
userId: userId!, userId: userId!,
@ -378,14 +386,17 @@ class GroupCall {
isWeb: voip.delegate.isWeb, isWeb: voip.delegate.isWeb,
isGroupCall: true, isGroupCall: true,
); );
} else {
localWrappedMediaStream = stream;
}
localUserMediaStream = newStream; localUserMediaStream = localWrappedMediaStream;
await localUserMediaStream!.initialize(); await localUserMediaStream!.initialize();
await addUserMediaStream(newStream); await addUserMediaStream(localWrappedMediaStream);
setState(GroupCallState.LocalCallFeedInitialized); setState(GroupCallState.LocalCallFeedInitialized);
return newStream; return localWrappedMediaStream;
} }
Future<void> updateAudioDevice() async { Future<void> updateAudioDevice() async {
@ -406,16 +417,15 @@ class GroupCall {
} }
/// enter the group call. /// enter the group call.
Future<void> enter() async { Future<void> enter({WrappedMediaStream? stream}) async {
if (!(state == GroupCallState.LocalCallFeedUninitialized || if (!(state == GroupCallState.LocalCallFeedUninitialized ||
state == GroupCallState.LocalCallFeedInitialized)) { state == GroupCallState.LocalCallFeedInitialized)) {
throw Exception('Cannot enter call in the $state state'); throw Exception('Cannot enter call in the $state state');
} }
if (state == GroupCallState.LocalCallFeedUninitialized) { if (state == GroupCallState.LocalCallFeedUninitialized) {
await initLocalStream(); await initLocalStream(stream: stream);
} }
await _addParticipant( await _addParticipant(
(await room.requestUser(client.userID!, ignoreErrors: true))!); (await room.requestUser(client.userID!, ignoreErrors: true))!);