From 814a363387ea354e33f3d47a7f0d5df8ebd60acd Mon Sep 17 00:00:00 2001 From: Krille Date: Wed, 18 Dec 2024 09:58:05 +0100 Subject: [PATCH 1/2] build: Update dev dependencies and remove unused dependencies --- pubspec.yaml | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/pubspec.yaml b/pubspec.yaml index ffc22f5c..e0391cd3 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -35,12 +35,10 @@ dependencies: webrtc_interface: ^1.2.0 dev_dependencies: - build_runner: ^2.4.13 coverage: ">=0.15.0 <2.0.0" - enhanced_enum_generator: ^0.2.4 file: ">=6.1.1 <8.0.0" import_sorter: ^4.6.0 lints: ^5.0.0 - path: ^1.9.0 - sqflite_common_ffi: ^2.3.2+1 # sqflite_common_ffi aggressively requires newer dart versions - test: ^1.15.7 + path: ^1.9.1 + sqflite_common_ffi: ^2.3.4+4 # sqflite_common_ffi aggressively requires newer dart versions + test: ^1.25.13 From e2f37c2acea6c280b64b1913db0e96efc8b2bfa9 Mon Sep 17 00:00:00 2001 From: Krille Date: Wed, 18 Dec 2024 11:03:53 +0100 Subject: [PATCH 2/2] chore: Dispose all clients in test --- .github/workflows/app.yml | 2 +- scripts/test.sh | 2 +- test/client_test.dart | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/app.yml b/.github/workflows/app.yml index cdd83e2c..91e5529d 100644 --- a/.github/workflows/app.yml +++ b/.github/workflows/app.yml @@ -129,7 +129,7 @@ jobs: - name: Run tests run: | dart pub get - dart test test/box_test.dart --platform chrome --fail-fast + dart test test/box_test.dart --platform chrome pub-dev-dry-run: runs-on: ubuntu-latest diff --git a/scripts/test.sh b/scripts/test.sh index 3aa45815..84207a80 100755 --- a/scripts/test.sh +++ b/scripts/test.sh @@ -6,7 +6,7 @@ if [ -n "$NO_OLM" ]; then tagFlag="-x olm" fi -dart test --concurrency=$thread_count --coverage=coverage_dir $tagFlag --fail-fast +dart test --concurrency=$thread_count --coverage=coverage_dir $tagFlag TEST_CODE=$? # lets you do more stuff like reporton diff --git a/test/client_test.dart b/test/client_test.dart index 0cf30862..162fb222 100644 --- a/test/client_test.dart +++ b/test/client_test.dart @@ -109,7 +109,7 @@ void main() { }); test('Login', () async { - final matrix = Client( + matrix = Client( 'testclient', httpClient: FakeMatrixApi(), databaseBuilder: getDatabase,