OfficialDakari
/
matrix-dart-sdk
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #1547 from famedly/krille/request-participants-cache 

feat: Add option to not cache users in memory when requesting all of …
This commit is contained in:
mErrenst 2023-08-16 09:15:56 +00:00 committed by GitHub
parent d7f03708cc 0c60ad7acd
commit b17f3a47f2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
lib/src/room.dart
View File

@ -1535,13 +1535,16 @@ class Room {
/// List `membershipFilter` defines with what membership do you want the /// List `membershipFilter` defines with what membership do you want the
/// participants, default set to /// participants, default set to
/// [[Membership.join, Membership.invite, Membership.knock]] /// [[Membership.join, Membership.invite, Membership.knock]]
/// Set [cache] to `false` if you do not want to cache the users in memory
/// for this session which is highly recommended for large public rooms.
Future<List<User>> requestParticipants( Future<List<User>> requestParticipants(
[List<Membership> membershipFilter = const [ [List<Membership> membershipFilter = const [
Membership.join, Membership.join,
Membership.invite, Membership.invite,
Membership.knock, Membership.knock,
], ],
bool suppressWarning = false]) async { bool suppressWarning = false,
bool cache = true]) async {
if (!participantListComplete && partial) { if (!participantListComplete && partial) {
// we aren't fully loaded, maybe the users are in the database // we aren't fully loaded, maybe the users are in the database
final users = await client.database?.getUsers(this) ?? []; final users = await client.database?.getUsers(this) ?? [];
@ -1557,7 +1560,7 @@ class Room {
} }
final memberCount = summary.mJoinedMemberCount; final memberCount = summary.mJoinedMemberCount;
if (!suppressWarning && memberCount != null && memberCount > 100) { if (!suppressWarning && cache && memberCount != null && memberCount > 100) {
Logs().w(''' Logs().w('''
Loading a list of $memberCount participants for the room $id. Loading a list of $memberCount participants for the room $id.
This may affect the performance. Please make sure to not unnecessary This may affect the performance. Please make sure to not unnecessary
@ -1570,10 +1573,14 @@ class Room {
?.map((e) => Event.fromMatrixEvent(e, this).asUser) ?.map((e) => Event.fromMatrixEvent(e, this).asUser)
.toList() ?? .toList() ??
[]; [];
for (final user in users) {
setState(user); // at *least* cache this in-memory if (cache) {
for (final user in users) {
setState(user); // at *least* cache this in-memory
}
} }
_requestedParticipants = true;
_requestedParticipants = cache;
users.removeWhere((u) => !membershipFilter.contains(u.membership)); users.removeWhere((u) => !membershipFilter.contains(u.membership));
return users; return users;
} }