From c0c95b1d64c910e9a392f959b9ab42c9baac70e1 Mon Sep 17 00:00:00 2001 From: Nicolas Werner Date: Mon, 18 Sep 2023 17:19:05 +0200 Subject: [PATCH] ci: don't fail fast on dendrite failure --- .github/workflows/app.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/app.yml b/.github/workflows/app.yml index 6cb18ccf..95e7d19f 100644 --- a/.github/workflows/app.yml +++ b/.github/workflows/app.yml @@ -18,6 +18,8 @@ jobs: strategy: matrix: homeserver: [synapse, dendrite, conduit] + # since the dendrite job is optional, actually run all tests to the end instead of failing on first error. + fail-fast: false steps: - uses: actions/checkout@v3 - name: Run tests @@ -36,8 +38,8 @@ jobs: scripts/prepare.sh scripts/test_driver.sh" -# coverage is done on the flutter-linux image because we setup olm there -# coverage_without_olm is done on dart images because why not :D + # coverage is done on the flutter-linux image because we setup olm there + # coverage_without_olm is done on dart images because why not :D coverage: runs-on: ubuntu-latest container: