OfficialDakari
/
matrix-dart-sdk
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: group calls terminator having sync glares 

this will be removed with the new calls, we should ignore expired calls rather than cleaning up unless you have complete ownership of the event
This commit is contained in:
td 2024-02-13 11:34:28 +01:00
parent 231399fe16
commit c2a2e419cb
No known key found for this signature in database
GPG Key ID: 62A30523D4D6CE28
1 changed files with 24 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
lib/src/voip/voip_room_extension.dart
View File

@ -56,31 +56,40 @@ extension GroupCallUtils on Room {
if (call != null) { if (call != null) {
return call.devices.where((device) => device.expires_ts != null).every( return call.devices.where((device) => device.expires_ts != null).every(
(device) => (device) =>
device.expires_ts! < DateTime.now().millisecondsSinceEpoch); (device.expires_ts ?? 0) +
staleCallCheckerDuration
.inMilliseconds < // buffer for sync glare
DateTime.now().millisecondsSinceEpoch);
} else {
Logs().d(
'[VOIP] Did not find $groupCallId in member events, probably sync glare');
return false;
} }
} } else {
// Last 30 seconds to get yourself together.
// This saves us from accidentally killing calls which were just created and
// whose state event we haven't recieved yet in sync.
// (option 2 was local echo member state events, but reverting them if anything
// fails sounds pain)
// Last 30 seconds to get yourself together. final expiredfr = groupCallMemberStateEvent.originServerTs
// This saves us from accidentally killing calls which were just created and .add(staleCallCheckerDuration)
// whose state event we haven't recieved yet in sync. .millisecondsSinceEpoch <
// (option 2 was local echo member state events, but reverting them if anything DateTime.now().millisecondsSinceEpoch;
// fails sounds pain)
final expiredfr = groupCallMemberStateEvent.originServerTs if (!expiredfr) {
.add(staleCallCheckerDuration) Logs().d(
.millisecondsSinceEpoch < '[VOIP] Last 30 seconds for state event from ${groupCallMemberStateEvent.senderId}');
DateTime.now().millisecondsSinceEpoch; }
if (!expiredfr) { return expiredfr;
Logs().d(
'[VOIP] Last 30 seconds for state event from ${groupCallMemberStateEvent.senderId}');
} }
return expiredfr;
} }
/// checks for stale calls in a room and sends `m.terminated` if all the /// checks for stale calls in a room and sends `m.terminated` if all the
/// expires_ts are expired. Called regularly on sync. /// expires_ts are expired. Called regularly on sync.
Future<void> singleShotStaleCallCheckerOnRoom() async { Future<void> singleShotStaleCallCheckerOnRoom() async {
if (partial) return; if (partial) return;
await client.oneShotSync();
final copyGroupCallIds = final copyGroupCallIds =
states.tryGetMap<String, Event>(EventTypes.GroupCallPrefix); states.tryGetMap<String, Event>(EventTypes.GroupCallPrefix);