OfficialDakari
/
matrix-dart-sdk
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: Make parse version error less sound

This commit is contained in:
Krille 2024-12-17 11:46:34 +01:00
parent bc7b987772
commit c58f55c012
No known key found for this signature in database
GPG Key ID: E067ECD60F1A0652
4 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/app.yml vendored
View File

@ -129,7 +129,7 @@ jobs:
- name: Run tests - name: Run tests
run: | run: |
dart pub get dart pub get
dart test test/box_test.dart --platform chrome dart test test/box_test.dart --platform chrome --fail-fast
pub-dev-dry-run: pub-dev-dry-run:
runs-on: ubuntu-latest runs-on: ubuntu-latest

5
lib/src/utils/versions_comparator.dart
View File

@ -13,11 +13,10 @@ bool isVersionGreaterThanOrEqualTo(String version, String target) {
} }
return true; return true;
} catch (e, s) { } catch (e) {
Logs().e( Logs().w(
'[_isVersionGreaterThanOrEqualTo] Failed to parse version $version', '[_isVersionGreaterThanOrEqualTo] Failed to parse version $version',
e, e,
s,
); );
return false; return false;
} }

2
scripts/test.sh
View File

@ -6,7 +6,7 @@ if [ -n "$NO_OLM" ]; then
tagFlag="-x olm" tagFlag="-x olm"
fi fi
dart test --concurrency=$thread_count --coverage=coverage_dir $tagFlag dart test --concurrency=$thread_count --coverage=coverage_dir $tagFlag --fail-fast
TEST_CODE=$? TEST_CODE=$?
# lets you do more stuff like reporton # lets you do more stuff like reporton

2
test/client_test.dart
View File

@ -109,7 +109,7 @@ void main() {
}); });
test('Login', () async { test('Login', () async {
matrix = Client( final matrix = Client(
'testclient', 'testclient',
httpClient: FakeMatrixApi(), httpClient: FakeMatrixApi(),
databaseBuilder: getDatabase, databaseBuilder: getDatabase,