From de5f4542185825c873f39046e9c22c4052277a59 Mon Sep 17 00:00:00 2001
From: Nicolas Werner <n.werner@famedly.com>
Date: Wed, 31 Jul 2024 20:18:51 +0200
Subject: [PATCH] fix: don't restart github action service after apt install

By default apt-get seems to restart services now, but that restarts the
github actions runner and cancels our job... Add the github actions
service to the exluded services.

See also https://discourse.ubuntu.com/t/needrestart-changes-in-ubuntu-24-04-service-restarts/44671
---
 .github/workflows/app.yml | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/app.yml b/.github/workflows/app.yml
index 360a8071..de872201 100644
--- a/.github/workflows/app.yml
+++ b/.github/workflows/app.yml
@@ -49,7 +49,6 @@ jobs:
           path: coverage_dir/
           retention-days: 1
 
-
   coverage:
     runs-on: arm-ubuntu-latest-16core
     steps:
@@ -61,6 +60,10 @@ jobs:
           architecture: "arm64"
       - name: Run tests
         run: |
+          # Prevent restarting the github actions service on package upgrades
+          # See https://discourse.ubuntu.com/t/needrestart-changes-in-ubuntu-24-04-service-restarts/44671
+          echo '$nrconf{override_rc}{qr(^actions.runner.*.service$)} = 0;' | sudo tee /etc/needrestart/conf.d/githubactions.conf
+
           sudo apt-get update && sudo apt-get install --no-install-recommends --no-install-suggests -y lcov libsqlite3-0 libsqlite3-dev libolm3 libssl3
           ./scripts/test.sh
       - uses: actions/upload-artifact@v4
@@ -70,7 +73,6 @@ jobs:
           path: coverage_dir/
           retention-days: 1
 
-
   merge_converage:
     if: ${{ !cancelled() }}
     runs-on: ubuntu-latest