OfficialDakari
/
matrix-dart-sdk
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Workaround for null boolean 

deviceKeysList.outdated is not nullable but we have seen this error
in production: `Failed assertion: boolean expression must not be null`
So this could either be a null safety bug in Dart or a result of
using unsound null safety. The extra equal check `== true` should
safe us here
This commit is contained in:
Krille Fear 2021-11-23 13:37:46 +01:00
parent 5da0180f1f
commit ee21121a63
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/src/client.dart
View File

@ -1813,7 +1813,13 @@ class Client extends MatrixApi {
final deviceKeysList = final deviceKeysList =
_userDeviceKeys[userId] ??= DeviceKeysList(userId, this); _userDeviceKeys[userId] ??= DeviceKeysList(userId, this);
final failure = _keyQueryFailures[userId.domain]; final failure = _keyQueryFailures[userId.domain];
if (deviceKeysList.outdated &&
// deviceKeysList.outdated is not nullable but we have seen this error
// in production: `Failed assertion: boolean expression must not be null`
// So this could either be a null safety bug in Dart or a result of
// using unsound null safety. The extra equal check `!= false` should
// save us here.
if (deviceKeysList.outdated != false &&
(failure == null || (failure == null ||
DateTime.now() DateTime.now()
.subtract(Duration(minutes: 5)) .subtract(Duration(minutes: 5))